Alexandre Quercia

@thePanz it's done See #363 for topic patches of test environment that allow me to work on this.

> There was a point when PR was doing perfectly what you set out to do. But the changes that have been made since then have made it impossible to...

The diff before class extraction https://github.com/FriendsOfSymfony1/symfony1/pull/301/files/fbc40e7396a0f0da445585c57cc2486d243d75ae

@thePanz I agree too. What do you suggest? Does it needs to extract the class extraction on another PR, or it is enough to have it on a dedicated commit...

> I propose a separate PR for cleaning, cs-fix and separation. #### To rephrase * One PR: make it work * with clean lime tests * with minimum code to...

@connorhu It is something between. To be able to clean the code (having a better code structure). => The prerequisite is to have a test suite that you trust, if...

I am closing this PR. In order to provide a fix 100% understandable and transparent. 1. I will create a new PR with the proof of the current behaviour. a....

Okay, @connorhu thanks for your feedback. Let's go, I will keep open this PR with force push when step 1 is done.

1st step done #371

> With a lot of code, I didn't have time to migrate my base code to the new version. 5 years ago, I had a dream. ```sh ./symfony project:migrate-to-version-4 ```...