symfony1 icon indicating copy to clipboard operation
symfony1 copied to clipboard

Published 20 hours ago • verified publisher icon FriendsOfSymfony1

[DoctrinePlugin] fix Swift_DoctrineSpool::queueMessage argument compatibility error

Open connorhu opened this issue 11 months ago • 6 comments

phpstan reported error

connorhu avatar Mar 21 '24 07:03 connorhu

Not so nice the green status with a php error. :( Our testing system is not good enough yet.

connorhu avatar Mar 21 '24 07:03 connorhu

IIRC this depends on the version of SwiftMailer installed, or I am wrong?

@thirsch @mentalstring @alquerci I remember you worked on this topic before

thePanz avatar Mar 21 '24 08:03 thePanz

IIRC this depends on the version of SwiftMailer installed, or I am wrong?

If this is true, we are not compatible with the latest version.

connorhu avatar Mar 21 '24 09:03 connorhu

@thePanz I have done a patch there https://github.com/FriendsOfSymfony1/symfony1/pull/302/files#diff-5d71b552c7a0ef74e4a9d348d29f677871db2cd0b8098308d94932d87b030dbd

alquerci avatar Mar 21 '24 13:03 alquerci

IIRC this depends on the version of SwiftMailer installed, or I am wrong?

If this is true, we are not compatible with the latest version.

Unfortunately, that's true. But changing it with this pr would break support for 5.x - Either we do drop 5.x or we should use a patch like the one from @alquerci. Another approach can be found in https://github.com/FriendsOfSymfony1/symfony1/pull/279.

thirsch avatar Mar 24 '24 19:03 thirsch

To summarize: we support two versions of a library at the same time that is no longer being developed, another one should be used, but the right direction would be to make the framework not require any mail-related library. Nice.

connorhu avatar Mar 25 '24 05:03 connorhu