Alja Mrak Tadel
Alja Mrak Tadel
@namapane Great! I did test with cvmfs. It took some time (more than 10min) to create the project, but then it worked.
@makortel This enum is used for different view types. E.g. 3D, projected views, glimpse , histogram, table type views etc. There are different types of histogram (or lego) views. Same...
@makortel There is bitwise left shit operators kLegoBit = 16 k3DBit | kRhoPhiBit = 3 I agree the whole process of plugin registration and the operators in quite convoluted.
@makortel I see .. It should be ``` FWViewType::kLegoBit | FWViewType::kLegoHFBit ); ```
@makortel @iarspider What should we do with this PR?
> In my opinion it would be good to replace the `EBit` enum with `static constexpr unsigned int` constants, and then fix the line as @alja suggested in [#45076 (comment)](https://github.com/cms-sw/cmssw/pull/45076#issuecomment-2136163268)...
> @alja , please use `+1` or `+visualization` comment to approve the PR. cms-bot does not use the reviewer's approval for signatures :-) @smuzaffar Thanks for letting me know.