[CPP20][Visualization] Remove deprecated implicit capture of this in FWTEveViewer

[iarspider]

PR description:

Remove deprecated implicit capture of this in FWTEveViewer:

src/Fireworks/Core/src/FWTEveViewer.cc: In lambda function:
  src/Fireworks/Core/src/FWTEveViewer.cc:80:27: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated]
    80 |   m_thr = new std::thread([=]() {
      |                           ^
src/Fireworks/Core/src/FWTEveViewer.cc:80:27: note: add explicit 'this' or '*this' capture

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45078/40394

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Fireworks/Core (visualization)

@alja, @Dr15Jones, @makortel, @cmsbuild can you please review it and eventually sign? Thanks. @alja this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for CMSSW_14_1_CPP20_X

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9785eb/39581/summary.html COMMIT: 4e40d5c94492720097d5cfab1f019eed368fa2af CMSSW: CMSSW_14_1_CPP20_X_2024-05-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45078/39581/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2619 lines to the logs
• Reco comparison results: 123 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 902
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337940
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9785eb/39582/summary.html COMMIT: 4e40d5c94492720097d5cfab1f019eed368fa2af CMSSW: CMSSW_14_1_X_2024-05-28-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45078/39582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338842
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@alja , please use +1 or +visualization comment to approve the PR. cms-bot does not use the reviewer's approval for signatures :-)

[iarspider]

@cms-sw/visualization-l2 gentle ping

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[alja]

@alja , please use +1 or +visualization comment to approve the PR. cms-bot does not use the reviewer's approval for signatures :-)

@smuzaffar Thanks for letting me know.

[rappoccio]

+1