Alja Mrak Tadel

icon indicating an email [email protected]

icon company UCSD icon location San Diego, CA

Results 36 comments of Alja Mrak Tadel

Problem in dumping Fireworks Geometry

@smuzaffar I don't know how the PR in some other package can trigger unit tests in Fireworks/Geometry. Now I'm not even sure if reco geometry and sim geometry dumper are...

[RFC] improve handling of phase-2 geometries and add unit tests for `Fireworks/Geometry` package

+1

[RFC] improve handling of phase-2 geometries and add unit tests for `Fireworks/Geometry` package

@mmusich Thank you very much for the unit test and the improvements in the dumpRecoGeometry_cfg.py!

[RFC] improve handling of phase-2 geometries and add unit tests for `Fireworks/Geometry` package

+1

[reve] Improvements in camera control and frustum update. REveBoxSet correction.

@linev Please check.

ROOT's TH1::AddDirectory is not thread safe

@Dr15Jones Fireworks creates a histogram in memory for calorimeter visualization. The TH1::AddDirectory(kFALSE) is called in all 3 places. Here is the example: https://github.com/cms-sw/cmssw/blob/master/Fireworks/Core/src/Context.cc#L139-L146 The TH1::AddDirectory(kFALSE) is already called. Do I...