cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Revive MF map and XML geometry visualization

Open namapane opened this issue 1 year ago • 5 comments

PR description:

Update code and scripts for the Eve visualization of MF map and XML geometries, which was no longer working.

PR validation:

Verified that the updated example configuration scripts work.

namapane avatar May 23 '24 08:05 namapane

cms-bot internal usage

cmsbuild avatar May 23 '24 08:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45021/40312

  • This PR adds an extra 24KB to repository

cmsbuild avatar May 23 '24 08:05 cmsbuild

A new Pull Request was created by @namapane for master.

It involves the following packages:

  • Fireworks/Geometry (visualization)
  • MagneticField/GeomBuilder (reconstruction)

@mandrenguyen, @Dr15Jones, @cmsbuild, @alja, @jfernan2, @makortel can you please review it and eventually sign? Thanks. @alja this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 23 '24 08:05 cmsbuild

please test

mandrenguyen avatar May 24 '24 17:05 mandrenguyen

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f49e2e/39520/summary.html COMMIT: 029b11c2adba6e493f36b6be3c3c9d188863ddc9 CMSSW: CMSSW_14_1_X_2024-05-24-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45021/39520/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338836
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 24 '24 19:05 cmsbuild

+1

mandrenguyen avatar May 28 '24 09:05 mandrenguyen

+1

alja avatar May 28 '24 16:05 alja

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 28 '24 16:05 cmsbuild

@namapane I'm glad you still find the way to use TEve. Are you running event display remotely or through cvmfs?

BTW, I also saw you are using TEveDigitSets. This have been integrated recently integrated in web-eve (the coming root release 6.32) as ROOT::Experimental::REveDigitSet.

alja avatar May 28 '24 16:05 alja

@namapane I'm glad you still find the way to use TEve. Are you running event display remotely or through cvmfs?

Remotely (from a vnc session as plain X is too slow). I use this code rarely but AFAIK it's the only way to visualize the MF and an XML geometry at the same time. Are there other tools that can be used to visualize an XML geometry directly with similar functionality?

BTW, I also saw you are using TEveDigitSets. This have been integrated recently integrated in web-eve (the coming root release 6.32) as ROOT::Experimental::REveDigitSet.

Uhm actually I'm not the original author of this code (history goes back to the cvs->github migration), I just have been making some updates over time, but I'm not that fluent in the internals...

namapane avatar May 29 '24 06:05 namapane

+1

rappoccio avatar May 29 '24 15:05 rappoccio

@namapane Just for the test I setup cvmfs on my local desktop. Now I can run cmsRun and cmsShow from cvmfs locally. I chose cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre4 project. The cmsRun Fireworks/Geometry/python/cmsRun_displayGeom_cfg.py opened eve main window. But the scene is empty. I will wait for the release (CMSSW_14_1_0_pre45 I guess) for this to be included and run.

The test for this PR should be like the line below, right? cmsRun Fireworks/Geometry/python/cmsRun_displayGeom_cfg.py

alja avatar May 29 '24 18:05 alja

@alja , here is what is get running cmsRun Fireworks/Geometry/python/cmsRun_displayGeom_cfg.py :

image

One question, when you say you run cmsRun from cvmfs, how do you recompile the package?

I must say I have had variable success with different environments (al9/al8/different releases/running within a vnc session or from a linux machine connected to lxplus via ssh, etc. There seems to be some interplay between the architecture and release of the area where the job is started and the actual environment of the physical display. Typical errors I get are of this kind:

libGL error: MESA-LOADER: failed to open swrast: /usr/lib64/dri/swrast_dri.so: undefined symbol: LLVMInitializeAMDGPUTargetInfo, version LLVM_17 (search paths /usr/lib64/dri, suffix _dri)
libGL error: failed to load driver: swrast

I think I also got errors that resulted in nothing being displayed, but there was an error message printed out in the cmsRun output, can you check if there's any in yours?

For example: it ran fine in a CMSSW_14_1_0_pre3 area created on lxplus8 when connecting via ssh from the physical display of a private al9 machine at CERN, but I got an error on a CMSSW_14_1_0_pre3 area created on lxplus9 in the same environment. The same area that worked, does not if I follow the same steps but connect to the private machine via VNC. But the connection via VNC works in earlier releases (eg CMSSW_13_0_16)... I did not find the magic of what works and what not,

If your local desktop runs al9, can you also try to ssh lxplus8, create a CMSSW_14_1_0_pre3 area, pick this update and recompile, and see if it works? That should be very close to the setup that was working for me (pre3 and el9).

namapane avatar May 29 '24 22:05 namapane

We just figured out the libGL error: MESA-LOADER error on el9, you can fix it by doing: LD_PRELOAD="/lib64/libLLVM-17.so" cmsShow ... see https://cms-talk.web.cern.ch/t/phase2-geometry-visualization/41531

We run Fedora 39 (me) and 40 (Alja) on our desktops ... with cvmfs setup we can create CMSSW environment as usual, we use el9_amd64_gcc12 or gcc13 ... and then compile and run locally.

osschar avatar May 29 '24 23:05 osschar

@osschar : cool thank you! It solves the problem. Here the MF map with overlaid a section of the MF geomretry, ran through a VNC connection from remote, in CMSSW_14_1_0_pre3 on el9_amd64_gcc12:

image

@alja Does the test now work for you?

namapane avatar May 30 '24 12:05 namapane

@namapane Great! I did test with cvmfs. It took some time (more than 10min) to create the project, but then it worked.

alja avatar May 30 '24 15:05 alja