Andrew Liu
Andrew Liu
> we should be able to use the normal tagstore as the tags that are on replay are usually the same as errors / transactions. at least that was the...
> the tags that are on replay are usually the same as errors / transactions. Maybe we can use issue platform for now
Here's an example of a tag that's not applicable for replays and shouldn't be showing up: `transaction` https://sentry.slack.com/archives/C03USURCFBJ/p1723673755567199 I think using the TagStore would lead to a lot of these...
Do we need to worry about the failing checks, ex "Test Miscellaneous / Miscellaneous (latest) (3.12, ubuntu-20.04) (pull_request)"
I'll be changing up the logic a good bit, since Billy pointed out this version will count a replay in buffering mode as isRecording.
Hm actually I think the context is unnecessary.. just need some kind of store for the lastReplayId.
Downside is **we can no longer support tag keys with spaces** - see my_custom_tag change in the jest test. We also won't be able to support custom tags with the...
Ok things got weird when I tried testing tag keys wrapped with "". Ex the query `"quoted key":value` or `"quoted key":"quoted value"`. The `:` character gets parsed into the value...
> @aliu39 there are our docs for custom tags! https://docs.sentry.io/platforms/javascript/enriching-events/tags/ > > > > i don't think keys or values can have white space, have never seen that in practice....
> some feedback: this PR could have been broken up for easier reviewing, but overall looks good. 👍🏼 Got it, thanks for lmk!