Andrew Liu
Andrew Liu
Assuming this PR sends feedback+attach in same envelope, let me know before you merge so I can turn on the ingest FF! I'ts only set in s4s right now. -...
Unsure about naming - could be client_type, client_source_type..
> the event data is built off the issues Event type which doesn't have tags as optional Why are we getting tags = null then? Should there be typecheck errors...
> worth trying to get to 100% code coverage on this one, can see which lines are missing it @JoshFerge Looks like it's the request_user_id=None case, which happens when request.user...
> > > worth trying to get to 100% code coverage on this one, can see which lines are missing it > > > @JoshFerge > > > Looks like...
> > > > > worth trying to get to 100% code coverage on this one, can see which lines are missing it > > > > > @JoshFerge >...
cc @JoshFerge @cmanallen
Closes https://github.com/getsentry/team-replay/issues/112
Looks like this was closed by https://github.com/getsentry/develop/pull/1197
@michellewzhang this good to merge?