sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

feat(flags): Add LaunchDarkly Integration

Open aliu39 opened this issue 1 year ago • 1 comments

Ref:

  • https://github.com/getsentry/team-replay/issues/492

aliu39 avatar Oct 22 '24 03:10 aliu39

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (d78664d) to head (5218c7a). Report is 16 commits behind head on cmanallen/flags-open-feature-integration.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/flag_utils.py 40.00% 3 Missing :warning:
sentry_sdk/integrations/launchdarkly.py 91.17% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@                             Coverage Diff                              @@
##           cmanallen/flags-open-feature-integration    #3679      +/-   ##
============================================================================
- Coverage                                     84.33%   83.38%   -0.95%     
============================================================================
  Files                                           135      136       +1     
  Lines                                         14326    14537     +211     
  Branches                                       2413     2469      +56     
============================================================================
+ Hits                                          12082    12122      +40     
- Misses                                         1494     1666     +172     
+ Partials                                        750      749       -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/openfeature.py 84.00% <100.00%> (+9.00%) :arrow_up:
sentry_sdk/flag_utils.py 82.60% <40.00%> (-11.84%) :arrow_down:
sentry_sdk/integrations/launchdarkly.py 91.17% <91.17%> (ø)

... and 4 files with indirect coverage changes

codecov[bot] avatar Oct 22 '24 04:10 codecov[bot]

Do we need to worry about the failing checks, ex "Test Miscellaneous / Miscellaneous (latest) (3.12, ubuntu-20.04) (pull_request)"

aliu39 avatar Oct 25 '24 20:10 aliu39