Alistair Johnson

Results 112 comments of Alistair Johnson

Sounds good, I'll raise this issue on the OMOP CDM repository.

Nice - this is a good idea - I'd like your opinion on a change of approach. Initially, I wrote the first day queries, then later wrote "pivoted" queries: https://github.com/MIT-LCP/mimic-code/tree/master/concepts/pivot...

1) I don't think it's good to merge these without more thought, as you mentioned they are not necessarily the same but without looking at the map I can't be...

This was built using the v5 model (early 2018) so it may be related to more recent changes in the vocab. Unfortunately work on this project was paused for a...

Also, is `place_of_service_concept_id` the source value concept ID? https://github.com/MIT-LCP/mimic-omop/blob/a815d0acbdc79d14943c18888a5fae20e912c22d/extras/concept/care_site.csv

I see - so let me clarify. Right now for example we have: * NSURG * Neurologic Surgical - surgical, relating to the brain * place_of_service_concept_id = 45773132 * visit_detail_concept_id...

Isn't #2 pretty annoying for continuous development? Every time we find a new concept, we have to modify the schema.

Totally agreed, I just think versioning of tables is pretty difficult. I think it's easier to have "materialized view missing" as an error rather than "column missing". I haven't read...

One thing I think will be really useful are "pivot" tables that I have created. So for example, instead of the lab table being in a key-value store, it's instead...

As soon as we publish something on PhysioNet we have to be able to support it and the ETL isn't ready. We are currently building ETLs for other ICU datasets...