Alice Frosi
Alice Frosi
@vladikr would you mind to take a look to this PR when you have a bit of time?
> I think this looks good, just to be clear on semantics `vm.status.volumeMigration` will always represent the status of the current or last migration. If a user wanted to know...
@mhenriks I added the conditions instead of the bool, could you please take another look? The commit https://github.com/kubevirt/kubevirt/pull/12355/commits/d9c88cade1a0d947b08ee1110e28445625c5cae1 describes how the conditions are set
@vladikr @mhenriks after the discussion from yesterday, do you mind taking a look if you agree on the api and volume migration state in f1aed242b883f5d400e420e4a098b5e5d3f12296
@vladikr @mhenriks I encapuslate the volume migration state in the volume update state. i'll ask tomorrow in the sig-api if the change is fine for them
@mhenriks @vladikr are you happy with the current changes?
@vladikr @mhenriks PTAL, I have updated the PR with the new APi
@vladikr @mhenriks we can think of introducing some restriction for booting. However, I really would like to merge this if we agree on the API. I think we can improve...
> The API looks fine to me now. I'm only worried about the functionality. I don't believe users will look at the VM status and will run into an unbootable...