Alice Frosi

icon company Red Hat icon location Germany

Results 639 comments of Alice Frosi

e2e, storage-migration: Replace client Update operations with patch

Looks good /lgtm /unhold

vmsnapshot: Enable status subresource for snapshot.kubevirt.io api group

@mhenriks in general looks good, just some minor stuff /approve /hold to fix the comments

vmsnapshot: Enable status subresource for snapshot.kubevirt.io api group

/unhold /lgtm

[release-1.0] Remove handler cgroup pkg dep in virt-chroot

/approve

backend-storage: add RWO FS support

> > > @jean-edouard could you please open an upstream issue for https://issues.redhat.com/browse/CNV-50720 > > > > > > Wouldn't it be basically the same as #13112 ? > >...

vmsnapshot: when checking if a VM is running, ignore runStrategy

@mhenriks should we add a functional test that create a snapshot from a stopped VM with the RunStrategy=`RerunOnFailur`? Otherwise, the code looks good.

vmsnapshot: when checking if a VM is running, ignore runStrategy

Fine to me /approve

Replace the PatchOperation with the PatchSet

/test all

Replace the PatchOperation with the PatchSet

/test all

Replace the PatchOperation with the PatchSet

@xpivarc can you please take a look when you have a bit of time