Alex Ruiz

Revert introduction to subpackages for tests

2

For example, now all the tests for classes in org.fest.api are in different subpackages. We use the convention that tests reside in the same package (but different source folder) as...

Refactor "overridingErrorMessage" and "usingComparator" to keep methods in a chain as single units

6

The methods in the FEST-Assert API must be considered as individual units. As such, a method in the chain should not partially affect another method in the chain. Readability is...

Remove methods from *ArrayAssert that take an object to compare size

2

For example, we have a method that takes an Iterable and asserts that an array has the same size. This is unnecessary API explosion. We need to draw the line...

Remove methods from *ArrayAssert that check is sorted

2

This is another case of API explosion. Users can simply create the array they expect and check for equality. We already have a nice way to pass a Comparator.

Refactor ComparisonStrategy to have a single responsiblity

1

ComparisonStrategy's responsibility is to compare 2 objects, nothing more. Right now this interface has methods that should be in utility classes related to Iterables, arrays and strings.

Revert methods that return Iterable to return List (as it was originally intended)

3

Returning Iterable is, IMHO, a bad idea. You cannot ask an Iterable about its size, and you cannot access elements by index. The methods that I plan to revert are...