fest-assert-2.x icon indicating copy to clipboard operation
fest-assert-2.x copied to clipboard

Published 20 hours ago • verified publisher icon alexruiz

Refactor ComparisonStrategy to have a single responsiblity

Open alexruiz opened this issue 12 years ago • 1 comments

ComparisonStrategy's responsibility is to compare 2 objects, nothing more. Right now this interface has methods that should be in utility classes related to Iterables, arrays and strings.

alexruiz avatar Sep 14 '12 06:09 alexruiz

Yeah I know ... but if you move string comparison to Strings then Strings will depend on ComparisonStrategy (same thing with Iterables and Arrays). At the time I felt it wasn't right but if you consider it to be better, I won't disagree.

joel-costigliola avatar Sep 14 '12 08:09 joel-costigliola