Alex Eagle

Results 1034 comments of Alex Eagle

I believe this is not possible because we still have e2e tests to verify bazel-lib works for WORKSPACE users. See the failures on the attached PR where I tried it....

Error is `ERROR: no such package '@@io_bazel_rules_go//go': The repository '@@io_bazel_rules_go' could not be resolved: Repository '@@io_bazel_rules_go' is not defined` https://github.com/bazel-contrib/bazel-lib/actions/runs/12202661633/job/34043875001 Which is expected because we test that bazel-lib works with...

I believe Bazel 7 made this existing warning more noisy for some reason. It would be really useful if someone could bisect where this was introduced in Bazel, maybe that...

@UebelAndre We don't want globs since that produces thousands of input files. We just want one input directory. It's Bazel's fault :) @opicaud I think that's a different issue about...

It would be a massive performance regression to hand Bazel an input file for every file in the node_modules directory, so I don't think we'd consider turning that on for...

@jesses-canva that's a clever idea - but currently we need access to some files inside the package earlier (e.g. repository rule needs to read package.json) so it's not enough to...

It's only partially fixed. Packages with lifecycle hooks still use source directories. @fmeum is improving support for them in Bazel itself.

Hm, we still support Bazel 6 in bazel-lib 2.x, and CI failure there is ``` ERROR: /home/runner/work/bazel-lib/bazel-lib/e2e/smoke/BUILD.bazel:97:10: While resolving toolchains for target //:bats: invalid registered toolchain '@bsd_tar_toolchains//:darwin_amd64_toolchain': error loading package...

@EdSchouten we're playing with https://github.com/google/triage-party today. It says I should ask you to merge - even though I should probably do the work myself :)

Alternatively I'm considering a 3.0 of bazel-lib (including the module rename from aspect_bazel_lib) so maybe we drop Bazel 6 support