Alex Eagle
Alex Eagle
Looking at the code it seems like https://github.com/aspect-build/rules_esbuild/blob/main/docs/esbuild.md#esbuild_bundle-args_file already gets merged into the launcher args. Seems like we just need to demo your use case in an example and document...
As a workaround, you could write another rule after the esbuild to sanitize paths in the file before passing it to write_source_files
@gonzojive as soon as we figure out the question of your org submitting bug bounties, this would be a good candidate.
Hi @danigar that's exciting to see such bleeding edge usage already :) Your plugin usage there depends on the "dynamic linker" in rules_nodejs, so that your call to `esbuild` will...
https://github.com/aspect-build/rules_esbuild/pull/11 is that example, however it's not working yet...
To be clear, we are reviewing the rules_js fixes right now so it's quite possible we'll have #11 merged this week. If you're okay staying on bleeding edge, we're happy...
The svg plugin is working now in https://github.com/aspect-build/rules_esbuild/pull/11
There is still a TODO for this https://github.com/aspect-build/rules_esbuild/blob/c12ccaeb0d97c3959250e7f81685c6296342b5c3/esbuild/private/esbuild.bzl#L163
I can't tell if this is actually still needed, or if writing a config file like /examples/plugin shows is easy enough that we can just drop the `esbuild_config` macro
those failures are blocking other PRs like https://github.com/bazelbuild/examples/pull/453 - @meteorcloudy do you know if anyone is buildcop for this repo?