Alex Eagle

Results 409 comments of Alex Eagle

For reference (in case that PR changes) here's what it looks like now ![rppe6slfkgb](https://user-images.githubusercontent.com/47395/35873798-a3222e3e-0b1f-11e8-84eb-a709c9c834ce.png)

err, sorry. it does add one, but it's green I think this is what I want https://github.com/Daniel15/BuildSize/blob/d5f12fc661b2236270158cc86ad7d23543b33ed1/app/Listeners/GitHubStatusListener.php#L38

It was commented out in this commit https://github.com/Daniel15/BuildSize/commit/659e6fea871265347d5d757cd8f8ea186fc4d7b9#diff-ec5c124326cf93ffb0186797120d22edR234 @Daniel15 do you remember why?

Answer from another thread: it was disabled until it can be configurable.

For reference, https://github.com/angular/angular/pull/22041 should have had a red status.

Another detail here: https://github.com/angular/angular/pull/22056 introduced a new artifact. The logic is to add the sizes, thus this means an overall size increase of the artifacts stored. In this issue, we'd...

Yes I'm working with @Toxicable on all the issues/FRs I filed, we're happy to contribute On Tue, Feb 13, 2018, 10:15 PM Daniel Lo Nigro wrote: > @Toxicable It makes...

I think it's better to update the comment. A reviewer who saw the previous comment needs to know it's fixed, otherwise they just wonder what happened to the comment (and...

It would be sufficient to start with to just provide the timeseries data, eg. do a small query against your DB and translate results to JSON. We can hook up...

_From @hansl on April 18, 2018 16:15_ Why not make this as part of the `ng new` experience directly? > provide facilities to easily add and remove the noindex metadata...