Alex Eagle

Results 1033 comments of Alex Eagle

@matthewjh do you have any idea the severity of this issue - meaning, have you seen some indication this flag is going to be flipped and users will be broken...

It seems like this flag isn't likely to be flipped https://github.com/bazelbuild/bazel/discussions/20500#discussioncomment-10623863 so I don't think we'd bother being compliant with its constraints.

In other repos I manage like rules_nodejs we have a bot send us PRs when there's a new version to mirror, e.g. https://github.com/bazelbuild/rules_nodejs/blob/stable/.github/workflows/update-nodejs-versions.yml I think this works well enough, the...

I filed this upstream: https://github.com/microsoft/TypeScript/issues/59036

I'll adopt that workaround to land the new version mirroring: https://github.com/aspect-build/rules_ts/pull/643 We'll see if there's progress from TS team, if not then I'll have to detect the error message and...

It's so gross :( :( https://github.com/aspect-build/rules_ts/pull/646/files

This is much improved after #720 - it should only affect users who explicitly set an `out_dir` attribute now.

LMK when this is ready, removing from my review dashboard

Rebased on the TS upgrade, so this example should be functional now. I'd still like to verify all the actions have expected inputs and outputs, and maybe add an analysis...

TypeScript doesn't ship a release yet that calls the new `transpileDeclaration` API, and I don't know of another tool that does. Maybe we'll have to cut scope here to just...