rules_esbuild icon indicating copy to clipboard operation
rules_esbuild copied to clipboard

Feature request: expose launcher_args in esbuild rule

Open livemixlove opened this issue 3 years ago • 2 comments

Currently there's no way to pass args directly to the ESBuild executable. I'd like to use the "log-override" arg (https://esbuild.github.io/api/#log-override), but I don't think there's any way to use this currently. Am I correct?

I think the way to do this would be to allow the user to pass through args into launcher_args: https://github.com/aspect-build/rules_esbuild/blob/main/esbuild/private/esbuild.bzl#L265

livemixlove avatar Oct 05 '22 16:10 livemixlove

@gregmagolan Any thoughts on providing a means for passing launcher args?

cgrindel avatar Oct 13 '22 17:10 cgrindel

Looking at the code it seems like https://github.com/aspect-build/rules_esbuild/blob/main/docs/esbuild.md#esbuild_bundle-args_file already gets merged into the launcher args. Seems like we just need to demo your use case in an example and document that as not only Internal Use ONly

alexeagle avatar Oct 20 '22 15:10 alexeagle