Alex Eagle

Results 412 comments of Alex Eagle

dupe of https://github.com/swc-project/swc/issues/3028 I think

Another TODO item: document the CLI options on the docsite somewhere. Right now tools like Bazel have to recommend that users run `swcx --help` to see how to use it.

We document that in a user example now too: https://github.com/aspect-build/rules_swc/commit/8db4ee5e5e26ba6dce331fca9164dbcfcdc1e1ff

FWIW I suspect that's not intentional. @titanous when you added the `--config` support, did you mean for the syntax to be different from `@swc/cli` ?

Note, I hit this with rules_oci as well: https://github.com/bazel-contrib/rules_oci/actions/runs/4865585708/jobs/8676166460 - and we haven't been able to enable windows testing on this repo under Bazel: https://github.com/GoogleContainerTools/container-structure-test/blob/main/.github/workflows/bazel.yaml#L16

@Monnoroch I fixed that line 5 years later :) https://github.com/GoogleContainerTools/container-diff/pull/395

The example does link the root - it just has the root in a subpackage of the workspace. https://github.com/aspect-build/rules_ts/blob/main/examples/BUILD.bazel#L35 is next to the `pnpm-lock.yaml` This is really a rules_js issue,...

I don't think this is correct, because we also need to release the binaries. It's a manual process, see https://github.com/GoogleContainerTools/container-structure-test/blob/main/repositories.bzl#L5

We should "spill" the argv into a flagfile, but it requires `protoc` to support that. Internally, Google handles this by modifying the kernel to allow a tremendous amount of data...

We should try adding an example under https://github.com/alexeagle/angular-closure-compatibility