Alex Eagle

Results 412 comments of Alex Eagle

First issue: Angular's closure-friendly ES6 distro uses ES modules, currently fails to produce the module deps graph: ``` SyntaxError: 'import' and 'export' may appear only with 'sourceType: module' (8:0) at...

yes: ``` $ git clone [email protected]:alexeagle/closure-compiler-angular-bundling.git $ git checkout splittable $ npm install && npm run build $ ./node_modules/.bin/splittable built/bootstrap.js Compilation failed: Parsing file /Users/alexeagle/Projects/closure-compiler-angular-bundling/node_modules/@angular/core/src/zone/ng_zone.js: 'import' and 'export' may appear...

I can workaround by locally modifying module-deps: https://github.com/substack/module-deps/blob/3b240bb25cf0229558b4c9d0395c2c3e3555376a/index.js#L451 It calls detective with no second argument (the opts). Workaround is: `detective(src, {parse: {sourceType: 'module'}})` I'm not sure if this is a...

Next problem: the graph produced by `splittable.js#getGraph` is incomplete. It does not seem to walk transitive imports - only ESModules directly imported by sources in the app are included in...

Note, @mlaval got Angular + Closure + lazy-loading working by hacking some bits from splittable: https://github.com/mlaval/optimize-angular-app/commit/9a1158392d30dcfd8e59cc344e2ae03474babb09 so we know it's possible. Just need to make the dev tooling easy enough...

It's broken when publishing to the BCR: https://buildkite.com/bazel/bcr-presubmit/builds/1430#01887d5b-4176-4c7b-9bf5-022e6efab0de I'll disable windows testing there for the v0.3.0 release.

@dzbarsky we do still need this, right?

I want **/*.ts minus node_modules/**/*.ts - that's the one I can't do with just glob On Mon, Feb 15, 2016 at 3:27 AM Martin Probst [email protected] wrote: > @filipesilva https://github.com/filipesilva...

And I think in a nodejs environment, globbing is well understood but piping together the find command is more advanced

Note also, we have a nearly identical setup in an Angular integration test: https://github.com/angular/angular/tree/master/integration/hello_world__closure The difference is the alexeagle/ one has zone.js as a separate `` while the angular/ one...