ngx-bootstrap install

[vforv]

Hello, is it possible to install ngx-bootstrap with closure and how?

http://valor-software.com/ngx-bootstrap/#/

Thanks, Vladimir

[alexeagle]

We should try adding an example under https://github.com/alexeagle/angular-closure-compatibility

[vforv]

I succeed to make it work for alert messages... Didn't try for other staff... If you test it let me know if everything ok with other staffs...

Just added this in conf: --js node_modules/ngx-bootstrap/**/*.js and then in module:

import { AlertModule } from 'ngx-bootstrap/alert';

[alexeagle]

The hard part is to find out whether any use cases are broken by closure compiler, which is a similar problem to test coverage. We need some e2e test suite that can be run after closure compiles the library. But what you have is the right way to start.

On Fri, May 26, 2017 at 6:15 AM Vladimir Djukic [email protected] wrote:

I succeed to make it work for alert messages... Didn't try for other staff... If you test it let me know if everything ok with other staffs...

Just added this in conf: --js node_modules/ngx-bootstrap/**/*.js and then in module:

import { AlertModule } from 'ngx-bootstrap/alert';

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/angular/closure-demo/issues/2#issuecomment-304279580, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC5IzYswZmL5Gw75Fkarz_EXkZaE0rQks5r9tB1gaJpZM4Nhq-B .

[vforv]

It would be great if you can test it, ngx bootstrap is widely used lib...

I found tests here: https://github.com/valor-software/ngx-bootstrap/tree/development/src/spec

Is it possible to compile all with closure and then run tests?

[alexeagle]

This requires more design... the tests would need to be compiled in the same pass by Closure Compiler so that property accesses in the tests are renamed along with the code they test. I don't believe this is a common pattern - instead we typically use protractor for black-box end-to-end tests that don't interact with the JS on the page.

On Fri, May 26, 2017 at 7:59 AM Vladimir Djukic [email protected] wrote:

It would be great if you can test it, ngx bootstrap is widely used lib...

I found tests here: https://github.com/valor-software/ngx-bootstrap/tree/development/src/spec

Is it possible to compile all with closure and then run tests?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/angular/closure-demo/issues/2#issuecomment-304305564, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC5Ixj03jN5LPV96pul0AI6fg-epmsxks5r9ujqgaJpZM4Nhq-B .

[alexeagle]

FWIW, note that ng-bootstrap now supports closure compiler: https://github.com/ng-bootstrap/ng-bootstrap/pull/1612