bazel-central-registry
bazel-central-registry copied to clipboard
bazelbuild
add libarchive 3.7.3 with tests and windows support
Based on https://github.com/zaucy/libarchive/tree/bazel-v3.7.3
- adds tests
- adds Windows support
Hello @dzbarsky, modules you maintain (libarchive) have been updated in this PR. Please review the changes.
@dzbarsky I would love your opinion on these changes since you were the original maintainer. If this works out I intend to subumit these changes for 3.7.2 as well.
some of the tests take an especially long time on the GitHub free action runners, but are quite fast locally. If they run slowly on the BCR buildkite CI then I may disable them or exclude them in the presubmit.
Thanks for submitting! I'm about to go on vacation for a week, I will do my best to find time to look before that
The presubmit is mostly green after I've excluded some tests (with added notes for any future readers.)
However, there is a patch error only on ubuntu arm64 for some reason. If anyone has any insight on that, it would be very helpful.
This fix is required to allow rules_js to work on windows. Can it be moved forward?
Since v3.7.3 is already in the registry, is this PR still relevant? Happy to merge once the module maintainers tell me to.
We still need this PR and/or a 3.7.4 with these changes applied on top.
From my POV, it's ready to go in, but @zaucy can make the final call on whether to change the config.h setup or keep as is.
There's also some issue with the patch not applying cleanly on one platform that we haven't gotten to the bottom of https://github.com/bazelbuild/bazel-central-registry/pull/1916#discussion_r1594523428
It would be nice to fix this before landing, but I think we need some help.
@zaucy anything else I'm missing?
yes currently https://github.com/bazelbuild/bazel-central-registry/pull/1916#discussion_r1594523428 is making me hesitant to say it's done. After that's resolved I'm happy to update this PR with 3.7.4.bcr.1 added as well.