Alex Eagle

Results 412 comments of Alex Eagle

I think we're missing a documentation update to consider it done

Bazel doesn't give any abilities here, it just spawns a subprocess with the flags we specify, and collects the declared output files from the bazel-out folder. I think users will...

Not that I know of... there is `--sandbox_default_allow_network` which would prevent opening network connections to remote hosts from actions, but otherwise unless someone invented a fancy sandbox I don't see...

Started this here: https://github.com/buildbuddy-io/buildbuddy/compare/master...alexeagle:master

current failure ``` ERROR: /home/alexeagle/Projects/buildbuddy/proto/BUILD:937:17: in _copy_to_bin rule //proto:_buildbuddy_service_ts_proto_pbjs_copy_srcs_to_bin: Traceback (most recent call last): File "/shared/cache/bazel/user_base/ed549a90e257f6c571ada9350158b663/external/aspect_bazel_lib/lib/private/copy_to_bin.bzl", line 101, column 38, in _impl files = copy_files_to_bin_actions(ctx, ctx.files.srcs, is_windows = is_windows) File...

cool, what repo did that commit come from? can you PR that to my `master` branch on `alexeagle` fork?

Or you could just carry forward on your own fork and send the PR from there, you don't need me involved :)

yeah clean those up so BB will accept your PR. Then we'll have a nice migrated-at-scale example to point ppl to.

Need to wait for RBE before they'll let this merge.

Rather than port this program to nodejs, I think we'll just wait for rules_pkg to support symlinks. We'll continue to have that transitive dependency on rules_python, sadly.