Alex Eagle

Results 412 comments of Alex Eagle

https://github.com/bazelbuild/bazel/pull/16272 is the PR we expect will fully resolve this, and should make it into Bazel 6.0 :)

Started this here: https://github.com/aspect-build/bazel-examples/tree/next/next.js currently failing in an interesting way - the first build fails ``` $ bazel clean; bazel build :build INFO: Starting clean (this may take a while)....

Note, https://github.com/aspect-build/bazel-examples/pull/44 is also pending work on top of the branch

https://github.com/aspect-build/bazel-examples/commit/cc7e16f3a79f48a0e8083a7f5704c6e6268bcd4b shows the working next.js workflows under Bazel. A couple of notes; - It required a bit of hacking, creating an entry point for running next.js which is outside of...

Yeah it exposes a dev dependency into a package that users load. I need to find a tricky way to put this in some other package, while still letting write_source_file...

Started this here: https://github.com/aspect-build/bazel-examples/tree/react/react/create-react-app Failing with ``` Creating an optimized production build... Failed to compile. SyntaxError: /shared/cache/bazel/user_base/0665ff20446a8ec57f994c91843cbe67/execroot/__main__/bazel-out/k8-fastbuild/bin/src/index.js: Support for the experimental syntax 'jsx' isn't currently enabled (9:3): 7 | const...

FYI @gregmagolan I upgraded to the 1.0.0 and still fails like this: ``` /shared/cache/bazel/user_base/94b49c00ba73c41eeaf34473af5ccd8a/sandbox/linux-sandbox/10/execroot/__main__/bazel-out/k8-opt-exec-2B5CBBC6/bin/build__js_binary.sh.runfiles/__main__/node_modules/.aspect_rules_js/[email protected]_qtbnez4q7bzoc4eqybg3efzzxe/node_modules/react-scripts/scripts/build.js:19 throw err; ^ RpcRemoteError: ENOENT: no such file or directory, realpath '/shared/cache/bazel/user_base/94b49c00ba73c41eeaf34473af5ccd8a/sandbox/linux-sandbox/10/execroot/__main__/bazel-out/k8-fastbuild/bin/node_modules/react' at enoent (/shared/cache/bazel/user_base/94b49c00ba73c41eeaf34473af5ccd8a/external/aspect_rules_js/js/private/node-patches/fs.js:752:15) at...

Note, this one does work for me https://github.com/heartless-clown/bazel_aspect_rules_js_react/blob/ejected/app/react-app/BUILD.bazel#L111-L112 though I think we'd want to review how that's done before cloning to our own examples.

Thanks Greg for getting it green

again, merging this doesn't have the desired effect since we bundle it. Maybe I can find time today to do the bundling under bazel so we can have a test...