Alec Grieser

Rename methods that change an index's state to indicate they are async

1

There a few methods that manipulate an index's state, and those are currently asynchronous as they can perform database reads (though, arguably, they should read those from memory and just...

In an unrelated PR (#270), the `ExtendedDirectoryLayerTest::testSetMappingWithConflicts` failed with the following error: ``` 12:13:20 com.apple.foundationdb.record.provider.foundationdb.keyspace.ExtendedDirectoryLayerTest > testSetMappingWithConflicts() FAILED 12:13:20 org.opentest4j.AssertionFailedError: nothing was added for the wrong value ==> Expected java.util.concurrent.CompletionException...

Mismatched boundary keys in FDBRecordStoreIndexTest::boundaryPrimaryKeys

1

At least one PR unrelated to the boundary keys work has failed to due an error in this function. The error encountered was: ``` com.apple.foundationdb.record.provider.foundationdb.FDBRecordStoreIndexTest > boundaryPrimaryKeys() FAILED org.opentest4j.AssertionFailedError: expected:...

testOrQuery5WithLimits intermittently fails with a NoSuchElementException

3

The `testOrQuery5WithLimits` test has intermittently failed with `NoSuchElementException` trying to pop from the queue: ``` 10:36:59 com.apple.foundationdb.record.provider.foundationdb.query.FDBOrQueryToUnionTest > testOrQuery5WithLimits(int)[1] FAILED 10:36:59 java.util.NoSuchElementException 10:36:59 at java.util.ArrayDeque.removeFirst(ArrayDeque.java:285) 10:36:59 at java.util.ArrayDeque.remove(ArrayDeque.java:452) 10:36:59 at...

Resolves #1857: DirectoryLayerDirectory creates new transactions during reverse lookup

5

This fixes up the `DirectoryLayerDirectory` to make use of the `LocatableResolver::reverseLookup` variant that takes an `FDBRecordContext` instead of just a timer. The latter was added as part of #1714 so...

Resolves #1847: TypeReposistory does not allow for named enums

8

This adds a "name" field to the enum type used by the type repository so that the user can associate a name for the enum type. When a user later...

The `DirectoryLayerDirectory` currently creates a new transaction when it does a reverse lookup here: https://github.com/FoundationDB/fdb-record-layer/blob/036443fe91fe822422fe0d732bfade3c91d68441/fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/DirectoryLayerDirectory.java#L282-L285 This is from an older time when the `LocatableResolver` didn't support reverse lookups without creating...

The TypeRepository currently always auto-generates the names for enums. However, in practice, I think we'll need enums to be able to take a user-supplied name. For example, that would be...

All of the `evaluateAggregateFunction` methods on `FDBRecordStore` (and friends) currently have no limits associated with them, and so they theoretically can do as much work as they want to answer...

In #1200, we updated the SpotBugs version, which but at the same time, turned spotbugsTest off to avoid some new SpotBugs failures in test code from stopping the upgrade. While...