fdb-record-layer icon indicating copy to clipboard operation
fdb-record-layer copied to clipboard

Published 20 hours ago • verified publisher icon FoundationDB

Resolves #1857: DirectoryLayerDirectory creates new transactions during reverse lookup

Open alecgrieser opened this issue 2 years ago • 5 comments

This fixes up the DirectoryLayerDirectory to make use of the LocatableResolver::reverseLookup variant that takes an FDBRecordContext instead of just a timer. The latter was added as part of #1714 so that lookups through the reverse directory layer could leverage an already initialized transaction's read version. The data here is write-once, so it is safe to read stale data (as long as the data aren't absent, and that case is retried with a new read version internally). This should decrease the amount of time it takes to list a key space path with values in the directory layer, as now, the operation doesn't need to create a new transaction if an initialized one already exists.

This resolves #1857.

alecgrieser avatar Oct 04 '22 14:10 alecgrieser

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 391128e43c19163d0dec63f85471bde2f7a676f4
  • Duration 0:15:23
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Oct 04 '22 14:10 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 391128e43c19163d0dec63f85471bde2f7a676f4
  • Duration 0:15:48
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Oct 04 '22 14:10 foundationdb-ci

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 06 '22 10:10 sonarqubecloud[bot]

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

  • Commit ID: 1530f39208b0d0f3dd68edaf0df9ef8277cbe569
  • Duration 0:15:40
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Oct 06 '22 10:10 foundationdb-ci

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

  • Commit ID: 1530f39208b0d0f3dd68edaf0df9ef8277cbe569
  • Duration 0:16:06
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Oct 06 '22 10:10 foundationdb-ci