Alec Grieser comments

Results 26 comments of


                                            Alec Grieser

Rename methods that change an index's state to indicate they are async

One thing to note: doing this *right now* will cause merge skew with #774, so this should only be done after #774 is in (or the PR to create it...

Resolves #1758: Add index scan plan with additional reads to load the RYW cache

Closing in favor of #1774

OnlineIndexerIndexFromIndexTest.testIndexFromIndexPersistentContinuePreviousByRecords() sometimes fails with "runner has been closed"

This caused the tests for #1295 to fail, but only for one of the PRB jobs

Potential bug on enable Multi-Threaded FDB client in FDBDatabaseFactory

Yeah, I believe that that's correct. Barring changes from the FDB core side to remove this requirement, the best we can do might be to update the comments on `setThreadsPerClientVersion`...

Mismatched boundary keys in FDBRecordStoreIndexTest::boundaryPrimaryKeys

Oh, and #306 appears to be a PR that failed because of this test.

Remove OnlineIndexer functions that take Key.Evaluateds

I'm not sure I understand the question. I think this is still an open issue, unless someone removed the `Key.Evaluated` methods or we decided that we _do_ want to keep...

Resolve #1804: Support remote fetch when no primary key can be calculated, remove common primary key from store interface.

Oh, whoops, after merging, I just noticed that this is missing a release note

Alec Grieser