Martti T.

For us would be use case - our application has API and background processes or shared services that log. During application start logger is created as very first thing. during...

closing, done with #45

about 2. - I assume original creator though process was to guard against data race when level value is changed. Underlying writer that does actual "output" is separate consern. Just...

I am little bit hesitant about this change. It removes guarantee for guarding data race on that field by assuming that no-one wants to change level during runtime for unknown...

somewhat resolved by #97 MTK is marked deprecated and newer `SentenceParser` does not add `MTK` as parser, it has `PMTK001` parser. Old global parser still supports `MTK`

At the moment I would suggest ```go p := nmea.NewSentenceParserWithConfig(nmea.SentenceParserConfig{ CustomParsers: map[string]nmea.ParserFunc{ "XYZ": func(s nmea.BaseSentence) (nmea.Sentence, error) { // This example uses the package builtin parsing helpers // you can...

alright, this should be better now. Changed mutex parts + `SenteceParser` is plain struct with public fields. `MTK` changes are resolved as - global Parse work with old `MTK` parser...

If it comes to merging some day - please use Squash or allow me to squash commits

This may not be relevant anymore for you @thanhnvh01 but FC17 is implemented now: [ReportServerIDRequest](https://github.com/aldas/modbus-tcp-client/tree/master/src/Packet/ModbusFunction/ReportServerIDRequest.php) / [ReportServerIDResponse](https://github.com/aldas/modbus-tcp-client/tree/master/src/Packet/ModbusFunction/ReportServerIDResponse.php)

Yes, I can add FC there.