Martti T.

Results 364 comments of Martti T.

Time when Request Logger middleware started can be read here https://github.com/labstack/echo/blob/c32fafad68daa7214f0ca005b4614ca38e90b2b8/middleware/request_logger.go#L128 > Since there will be many middleware, there is no way to know which middleware is executing first, so...

This is where latency is calculated. https://github.com/labstack/echo/blob/c32fafad68daa7214f0ca005b4614ca38e90b2b8/middleware/request_logger.go#L213-L225

I would not say it is inaccurate. it is good enough without delving into philosophical discussions what is accurate request time and what is not and when does request actually...

I would assume that part in [docs](https://github.com/labstack/echox/blob/master/website/content/middleware/body-dump.md) was referring to cases when you know body to be not worthy to be logged. ala you want to log usual API endpoints...

Probably by adding `FlushInterval` to `ProxyConfig` struct and assinging it to the proxy we created at https://github.com/labstack/echo/blob/61422dd7de9b0359708ff56b67099b91b5954c31/middleware/proxy.go#L279 also removing this case statement and letting it to fall into `default` https://github.com/labstack/echo/blob/61422dd7de9b0359708ff56b67099b91b5954c31/middleware/proxy.go#L256-L260...

This is done in `v5` proposal. Coloring is removed from whole Echo and startup messages are logged into logger. See this discussion for details https://github.com/labstack/echo/discussions/2000

Adding new methods to Context interface is problematic due backwards compatibility semantic versioning provides. There is a way to have default bind values already in library. See this example: ```go...

Notes for myself: * probably needs methods for FORM values also (we have `FormValue(name string) string`) * Echo and Gin API is quite similar. In Gin same methods have prefix...

Hi, to bind form data you need to add `form:"name"` to the struct field tag. Please see the documentation about that at https://echo.labstack.com/guide/binding/ ```go type SayHelloReq struct { Name string...

You could write `sed` `awk` etc command that does replacement/insertion for those protoc generated files and is executed after protoc call.