Martti T.

Just a note Github flow uses `go get -u golang.org/x/lint/golint@latest` but from Go 1.18 this way of installing commands is removed and `go install golang.org/x/lint/golint@latest` should be used. But `go...

Unless new struct and some ugly if are not added to separate PMTK001 from other MTK command - breaking change is way to go. In current form I think MTK...

@icholy and @adrianmo: I propose breaking change: * rename `MTK` struct to `PMTK001` * rename `TypeMTK` constant to `TypePMTK001` with value `MTK001` * remove talkerID and prefix related hacks from...

I have fundamental question about this `critical bug`. > jwt-go before 4.0.0-preview1 allows attackers to bypass intended access restrictions in situations with []string{} for m["aud"] (which is allowed by the...

just poiting out that you can not even marshal array to jwt.StandardClaim struct ```go func TestStandardClaims_VerifyAud(t *testing.T) { var testCases = []struct { name string token string }{ { name:...

why not just fix `MapClaims.VerifyAudience` with something like that if optional case is problematic ```go func (m MapClaims) VerifyAudience(cmp string, req bool) bool { rawAud, exists := m["aud"] if !exists...

this feature would be really helpful.

So far what I have come up is to have 2 extra functions in DSL that must be used for those variables in expression that come from configuration. * `v()`...

Would like to see it also. Maybe just refactor this block https://github.com/tuupola/slim-jwt-auth/blob/3.x/src/JwtAuthentication.php#L139 ``` $token = $this->fetchToken($request); $decoded = $this->decodeToken($token); ``` into protected method that we could override and add custom...

@bruc3mackenzi3 this seems ok but it would be better if we come up better name for that `## Fast Binding with Dedicated Helpers` section. I think we should distinquish these...