Martti T.

Results 364 comments of Martti T.

I think your import is wrong. Instead of `"github.com/labstack.echo/v4"` use `"github.com/labstack/echo/v4"` ```bash mkdir testimport cd testimport go mod init testimport cat > main.go main.go package main > > import (...

also you might want to run `go mod tidy` after you add `golangci-lint` ```bash x@x:~/code/test/testimport$ go get github.com/golangci/golangci-lint/cmd/golangci-lint go: downloading github.com/golangci/golangci-lint v1.39.0 ... ... ... go: downloading github.com/mattn/go-runewidth v0.0.9 go...

I think this would be OK if that `he.Internal` check would be included. Currently this PR is removing that "feature" so if you have set something to `internal` it would...

This is probably not that easy fix. `c.JSON` can fail because of other reasons other than object not being serializable. ala something wrong has happened to response writer. In that...

Hi @runner-mei , this may be controversial advice but you can copy the `RemoveTrailingSlash` middleware code and create you own middleware out of it and strip/change everything you need.

@sazzer are you sure that `http` or your cli is not converting that `%3f` to `?`. When I try with curl I get this ```bash x@x:~/code$ curl -v localhost:8000/example/abc%3fdef *...

Just some remarks: I'm not really sure what is correct fix. I'm not the author of that middleware but logger middleware is `access log`. It logs logs requests and (error)responses....

I think for this to work ```go if err = next(c); err != nil { c.Error(err) } ``` should be changed to ```go err = next(c) ``` Note to self:...

You might want to read this https://github.com/labstack/echo/issues/692#issuecomment-299738295 Binder read all data from request reader and default readers do not support reading it twice so you need workarounds for that.