Alan Protasio comments

Results 138 comments of


                                            Alan Protasio

Allowing ruler replication to be configurable for rules API HA

I understood the general ideal and LGTM. I did not reviewed every single line in detail but as its already have 3 approves im good with it.

OTLP native support

I think this makes lots of sense... I just dont know if the OTLP data model can be translated to prometheus data model with no lost (histograms?)..

Cortex 1.16.0 Upgrade Error:LabelValues() from merge generic querier for label

Are you seeing some impact? @yeya24 could this be because we fixed some context cancelletion propagation and now we are actually canceling the queries that times out? (if so this...

Introduce index cache tracing

LGTM

Fix yaml empty node validation

Can i sign the DCO?

Make per tenant queue size reloadable during runtime

/remove stale

Unshipped blocks when out of order writes are enabled

I will try to take a look on this this week! cc @yeya24

Cortex Ingester S3 upload fails with `x-amz-server-side-encryption` header error

I think if you define `SSE-S3` u must define the key. Can you try that?

Replace sort.Slice with slices.SortFunc

Can we merge this?

Fix panic on startup if the ExternalURL field in the ruler config is empty

Nice catch. Can you add a test for it? with a valid url as well?