cortex icon indicating copy to clipboard operation
cortex copied to clipboard
verified publisher icon cortexproject

Fix yaml empty node validation

Open kralicky opened this issue 2 years ago • 3 comments

What this PR does: This PR improves the yaml empty node validation for the cortex config by inspecting the yaml ast directly instead of checking the struct after unmarshaling.

Which issue(s) this PR fixes: Fixes #5488

Checklist

  • [x] Tests updated
  • [ ] Documentation added
  • [ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

kralicky avatar Jul 27 '23 16:07 kralicky

Can i sign the DCO?

alanprot avatar Aug 23 '23 00:08 alanprot

Sure, do you want me to update the changelog as well? or is that automated?

kralicky avatar Aug 23 '23 00:08 kralicky