Alan Protasio
Alan Protasio
Closing in favor of https://github.com/prometheus/prometheus/pull/12598 Thanks
Should we only set the config if its `!= 0` here? Just got a divided by 0 error when updating prometheus on thanos! :D https://github.com/thanos-io/thanos/pull/6392 https://github.com/prometheus/prometheus/blob/37e5249e33e4c2d7bc49c4ac587faf12eb6785b7/tsdb/db.go#L790 nervemind.. just saw the...
This is amazing.. I wonder if we should propose a new streamed QueryAPI (We should be able to stream by series like here or by steps?). Prometheus compatibles services like...
> > This is amazing.. > > I wonder if we should propose a new streamed QueryAPI (We should be able to stream by series like here or by steps?)....
Hi, thanks all for looking into this. This is indeed not a problem in most circumstances, but under certain scenario, some implementations could decide to reuse the request/slices objects after...
@dfawley Any thoughts on this? Do you think it make sense to re-check the context when "dequeueing" the write on the http client side?
> // Upon exiting, if the error causing the exit is not an I/O error, run() // flushes and closes the underlying connection. Otherwise, the connection is // left open...
>The component is not closed, it has simply returned an error. This behavior sounds like something that happens in many components (you call a function on a component and that...
>No, because you can't get around a race that way unless there's a lock involved. Even if you check it immediately before using it, if the context becomes canceled right...
@bboreham PTAL?