Alan Protasio
Alan Protasio
I think this looks good. Should we update the documentation about scaling down ingesters as well? Or we wanna do this in another PR?
This is a very interesting PR.. at some point i was thinking on doing something similar. @SungJin1212 were you able to do some load test on this to see how...
It seems that this may have the same root cause of https://github.com/emissary-ingress/emissary/pull/4447 Seems when we add the healthcheck, we create a new cluster with the same name and can trigger...
Ok... Indeed seems the same root cause of https://github.com/emissary-ingress/emissary/pull/4447 Seems that anything that changes the cluster object, can trigger this bug: I kept changing the `connect_timeout_ms` or `cluster_idle_timeout_ms` on the...
@yeya24 Update the PR to use the `MergeSlicesParallel` and added a bench. It seems better but maybe we need more tests? like with different number of labels being returned?
Approved... other than changing the ruler timeout config to be under the ruler_client section, it LGTM
/not-stale
This is being running for some time internally and seems that its good. Merging it!
>this is only valid if the deployment takes less than 2 hours, because of the shipping every 2 hours. Yeah.. we can achieve this easily using https://github.com/aws/zone-aware-controllers-for-k8s The question is...