Alan Cruickshank

Results 147 comments of Alan Cruickshank

I think I agree with your suggested indentation, the only thing I'm not sure about is the interaction with leading commas. In a trailing comma world, then I think we...

To be clear, I think with `tab_space_size` set to 2 and leading commas, the current _correct_ indentation should be as below (as per the current settings - happy to discuss...

Correct, indents are always relative to the _start_ of the previous line. > In other words, the indentation method doesn't take into account the relationship with the line above it....

I think this would be a great rule to implement, especially since the reflow work would make this _very_ easy. A carbon copy of `L008`, but without the restriction of...

@nimish-nimishmittal - of course. You're very welcome.

Yes - I can see that in the `FromPivotExpressionSegment`, it's currently just expecting a `SingleIdentifierGrammar` after `FOR` rather than a function (or even expression). While it's a different example, this...

Confirmed. The `TagBracketedEqualsSegment` grammar only allows `NakedIdentifierSegment` rather than anything with dots in it. We should probably having something more like `ObjectReferenceSegment` instead which would allow qualified names.

Confirmed. This is not present in the existing dialect. The sqllite docs for this syntax are here: https://www.sqlite.org/pragma.html I won't be able to pick this one up myself for a...

I'm going to close this issue because I think the desired functionality has now been implemented as https://docs.sqlfluff.com/en/stable/cli.html#cmdoption-sqlfluff-fix-show-lint-violations

So there's a development of this with #3942. The first two examples are now both corrected to: ```sql SELECT foo , SUM( some_long_expression ) ``` The comma doesn't open a...