Alan Cruickshank

Results 147 comments of Alan Cruickshank

This looks very likely to be a `dbt` issue rather than a sqlfluff one - but I'm not sure the best way to confirm that within the context of a...

Interesting! I hadn't thought about this particular application, but this does feel like a sensible extension of the rule. I think this an _enhancement_ rather than a bug because this...

Yeah I think this is a limitation with the current reflow rules. Either this should correct to: ```sql SELECT GREATEST( 1, 2, 3, 4, 5, 6 ); ``` or (the...

This is resolved in #3942. The first example will now be corrected to: ```sql SELECT GREATEST( 1, 2, 3, 4, 5, 6 ) ```

Create Table As statements are supported generally. This statement parses fine: `create table t1 as SELECT 1 as id;`. The part here that doesn't parse is the `engine = Log()`...

I've done a sense check through existing rules - and I agree that this should be a new one rather than an addition to an existing rule.

With the byte limit - it should _skip_ the file and not lock on it. Can you try setting `large_file_skip_byte_limit` to something really low and see whether you're still getting...

It's primarily the _parsing_ step rather than any others which takes the most time. To confirm this, you should be able to see the same slowdown when running `sqlfluff parse`...

I think there are two issues here: A parsing problem with date literals, and also a big in the new `TemplateLoop` segment with `L006`. I can certainly address the latter,...

@KulykDmytro - if I run your provided example query - I can recreate the issue with parsing - but not the critical error with the `TemplateLoop`. This probably won't occur...