Alan Cruickshank

Results 147 comments of Alan Cruickshank

I might be able to have a go at this while I try and unpick the remnants of #3692. I think they're related.

To make progress on this my suggestion builds on #3819. The introduction of `TypedMatcher` doesn't directly solve this problem, but I think it provides a potential path forward. The way...

My suggestion on this one would yes to be to go for a templater approach, especially if we don't need to work in conjunction with `jinja2` or `dbt`. There's an...

I think checking for the large file limit as early as possible makes sense. Ideally we'd do it when initially loading the file, using [os.path.getsize](https://docs.python.org/3/library/os.path.html#os.path.getsize) or similar.

No need to provide the rest of the query here, I think I can see what's going on. The logic about *where* to put line breaks when reformatting. I think...

Thanks for the extra intel @joellabes . I think your assessment of what *should ideally* happen is spot on. The current reflow logic looks for potential indent points within the...

@tekumara - why are your configuration values prefixed by `tool`? Can you confirm that you still experience this issue if you change your `.sqlfluff` file to: ```ini [sqlfluff] templater =...

> Think we might eventually want to require defining a new segment class in order to provide a new type string? 🤦 Yeah that would be much simpler 👍. Looking...

Most of the rules are now refactored with #3701. That at least unblocks #3668. Remaining work here is: - NamedParser still exists which I'd like to remove. - The link...

I don't know if this is a good first issue - I'm going to be covering a lot of the same ground with #3942 and #3673 . So let's see...