Andrew Lamb

Hi @46bit -- Thank you for offering. The idea of adding a `max_depth` parameter to the existing (non `pub`) methods seems reasonable to me. Hopefully the interface that most external...

I think a default depth limit (that can be overridden) seems very reasonable to me and very much in the rust "safe by default" spirit

> Those macros have to be defined in a separate crate I don't understand why they need to be in a separate crate Adding a macro to check recursion seems...

🤔 I am not sure how much time I have to devote to figuring out how to release multiple dependent crates in parallel for this crate

Thank you -- I am a little behind on sqlparser reviews at the moment. I'll try and take a look over the weekend. Hopefully we can get some other community...

> @alamb Thank you for the detailed review, I agree with pretty much all your points :) The overflow protection seems effective (we've been fuzzing it for a solid week...

Closing as stale -- please reopen if you still plan to work on it

I think the enum idea is a good one

FYI, I am planning to make a new sqlparser-rs release in the next day or two. This PR has some outstanding comments and appears to have have stalled

Marking as draft to signify this PR has been reviewed. Please mark this PR as ready for review when it is ready again.