Andrew Lamb

Marking this as a draft to show it is waiting some changes so I can easily filter out which PRs need review. Please mark it as "ready for review" when...

Closing as stale -- please reopen if you still plan to work on it

I agree with @nickolay -- it isn't clear to me what problem this proposal would solve. Can't users do something like ```rust let quote = match ident.quote { '\'' |...

> Actually @alamb I think the main problem is that it's an option, which is a pain to handle. The user would need to unwrap it to be able to...

I worry that changing `Ident` to be an enum will cause a substantial amount of downstream code churn, even if the downstream crate doesn't care about quoting

Hi @kyle-mccarthy -- I am sorry it looks like this PR never got reviewed and it has now bitrotted. If you would like to pursue this can you please update...

Closing as stale -- please reopen if you still plan to work on it

@AugustoFKL -- given that sqlparser uses an `enum` (that isn't explicitly declared `non_exhaustive` https://doc.rust-lang.org/reference/attributes/type_system.html) pretty much any change that adds a variant to one of the existing enums will be...

So "yes adding support for a DECLARE" statement is definitely acceptable from my perspective (like I will review it and help merge it)

Feel free to send to [email protected]