Andrew Lamb

Results 1174 comments of Andrew Lamb

I also plan to review this PR, but I may not get to it today

I plan to get this PR ready to merge by: add my suggested comments, fix clippy, and merge to master

(since I already have it checked out this will be a simple thing for me)

I am sorry for the late review here -- it is on my list. Basically I am struggling to find time enough to sit down and convince myself that this...

I would be willing to help write some more tests / comments for this PR if others think it is a good idea.

I took the liberty of merging this branch from master and resolving the merge conflict in fe582a7

Thanks again for sticking with this one @AssHero

The newly added TPCH plan benchmarks needed to be updated as well

Nice! Thanks everyone

@liukun4515 I wonder if we could make type coercion part of "simplify_expressions" 🤔 that way it would always be called at the appropriate time 🤔