Andrew Lamb

Results 1174 comments of Andrew Lamb

Marking this as a draft to show it is waiting some changes so I can easily filter out which PRs need review. Please mark it as "ready for review" when...

Another potential SQL standard was is to use `"` double quotes: `"name" = ?`

Thanks for the report -- it would be great if you could contribute a PR

I agree extending support for MapAccess sounds like a good idea to me 👍

Is the primary usecase of this proposal so that downstream code can re-use `AnalyzeStatement` directly?

I don't feel qualified to approve / accept this level of change without some additional buy in from @nickolay / @andygrove / @Dandandan . https://github.com/sqlparser-rs/sqlparser-rs/issues/311#issuecomment-902861958 seems like a good usecase...

Your guidance makes a lot of sense to me @nickolay -- thank you

Sadly I don't have the time to help drive projects such as this. Unless one of the other maintainers wants to do so, PRs like this are not likely to...

There is some prior art / discussion https://github.com/sqlparser-rs/sqlparser-rs/issues/301 https://github.com/sqlparser-rs/sqlparser-rs/issues/179 Here are some PRs that attempt to do the same thing: https://github.com/sqlparser-rs/sqlparser-rs/pull/288 https://github.com/sqlparser-rs/sqlparser-rs/pull/514 Basically the challenge of this will feature in...

I think if you make a PR that is likely the best way to get guidance.