Andrew Lamb
Andrew Lamb
Makes sense to me 👍
> @alamb first of all, should I do something with parse_deeply_nested_parens_hits_recursion_limits test? Because locally it's failed with stack overflow even in main branch. All others test result is ok. I...
> @alamb do you suggest to change `const DEFAULT_REMAINING_DEPTH: usize = 50;` in `src\parser\mod.rs` to `40` for example? Yes, this is basically my suggestion The rationale is that doing so...
You are not the first to hit this problem -- I think @universalmind303 saw it in https://github.com/sqlparser-rs/sqlparser-rs/pull/1144 Thus i think we need to do some real work -- I will...
I merged up from main and now this test is passing 🎉
Thanks again @Nikita-str -- this is a very nice contribution
Marking as Draft to signify this PR is no longer waiting on review. Please mark it as ready for review when it is ready for another look.
FWIW @Nikita-str has solved the stack overflow issues in https://github.com/sqlparser-rs/sqlparser-rs/pull/1171 if you wanted to revive this PR.
Here is a related discussion in sqlparser: https://github.com/sqlparser-rs/sqlparser-rs/issues/818
Marking as Draft to signify this PR is no longer waiting on review. Please mark it as ready for review when it is ready for another look.