Andrew Lamb comments

Results 1965 comments of


                                            Andrew Lamb

【bug】The error location is imprecise.

Thank you for the analysis @Nikita-str -- @baoyachi do you have a suggested fix for this issue?

Cannot parse table alias or cte alias in Postgres dialect

It would be great to figure out what is going on here and add the relevant support

Cannot parse table alias or cte alias in Postgres dialect

I wonder if it would be apprpriate to use [IdentWithAlias](https://docs.rs/sqlparser/latest/sqlparser/ast/struct.IdentWithAlias.html) instead of `ObjectName` 🤔

Expected end of statement, found: COMMENT while parsing MySQL `CREATE TABLE` statement

It looks to me like the parser doesn't quite handle parsing the entire set of mysql `CREATE TABLE` syntax. A fix would be most appreciated. Thank you for the report...

Stack overflow in `Statement::to_string` for deeply nested expresions

Thank you @jjbayer -- this would indeed be nice to fix. I do suspect this would be less likely to happen in release builds

clickhouse: add support for parsing ARRAY JOIN

This one appears to be stalled. Marking as Draft until we sort out what is needed

Suggest splitting `parser.rs` into smaller mod files

This basic plan seems reasonable to me, though it will cause substantial conflicts with anyone who as an outstaning PR 🤔

Suggest splitting `parser.rs` into smaller mod files

> @alamb If possible, we can break it up into some issues and PRs to step through this refactoring. Sounds like a good plan for me > Do you have...

Suggest splitting `parser.rs` into smaller mod files

> What are your thoughts on creating a trait Parse to implement for the structures/enums, instead of loose functions? I am not quite sure what you are proposing @AugustoFKL --...

Question: why is the Visitor trait limited to statements, relations & expressions?

> What is the reason for that particular design decision versus providing a more general Visitor implementation? The core reasons are to keep this crate easy to extend with new...