Andrew Lamb

Looks like there is a conflict (perhaps with one of your other PRs 😆 ) -- if you can resolve that I'll merge this PR in. Thanks again

🚀

Sure -- thank you @louisjoecodes https://github.com/sqlparser-rs/sqlparser-rs?tab=readme-ov-file#contributing describes the process and what types of things we accept The biggest challenge is review bandwidth -- so anything you can do to help...

> Sorry I also meant more financial donations, also happy to get one of our outsourced engineers to take a look at PRs Thanks @louisjoecodes -- as it turns out...

I think adding Domain as a keyword would be fine -- perhaps you want to contribute parsing support for the `CREATE DOMAIN` statement 🤔

Rather than removing `CopyOption` entirely, what about making an extension or other variant in `CopyOption` that is like `CopyOption::Other(Name, Value)` or soemthing? Any changes like this will be a breaking...

Another potential thought might be to keep the current postgres specific copy options but rename it to `PostgresCopy` and only parse with the postgres dialect, and then make a more...

> Instead of adding/modifying as described, could investigate ways to make it easier for downstream consumers to parse their own custom statements. I think this would be the best outcome...

> Would that suggest that [apache/arrow-datafusion#4808](https://github.com/apache/arrow-datafusion/issues/4808) would instead be focused on reducing the code of `DFParser` in DataFusion and not eliminate it entirely? I agree reducing the code is a...

It definitely sounds like a bug -- thank you for the report @baoyachi