Andrew Lamb

Results 1863 comments of Andrew Lamb

I would recommend finding a sql reference for the syntax (aka which database invented / used this syntax) to understand what `()` means in this context and then update the...

Thanks for the update @michael-2956 -- since this is an actual feature gap I'll plan to leave this issue open in case anyone else runs into the limitation and might...

> Maybe it have sense to split TableConstraint::Unique into TableConstraint::Unique & TableConstraint::Primary? Yes, I agree this would make more sense than trying to combine UNIQUE and PRIMARY KEY syntaxes together...

> But still maybe when they are separate it's more expected by an user, idk. I agree -- the sqlparser's crate[ aim is to preserve syntax](https://github.com/sqlparser-rs/sqlparser-rs?tab=readme-ov-file#syntax-vs-semantics) and it is up...

Thanks again @Nikita-str

Possibly related: https://github.com/sqlparser-rs/sqlparser-rs/pull/1156

> Regarding maintainership, sure I'm happy to help out in this regard and can allocate more time to reviews and tracking issues etc. Do let me know how to effectively...

> That sounds good to me! Will look to help out further in that case 👍 BTW if you see a PR that is ready to go in your opinion...

I am not sure what is going on @groobyming -- your description certainly sounds like a bug. Maybe there is code in the parser that is special casing HiveDialect rather...