akrieger
akrieger
``` diff --git a/src/third-party/imgui/imgui.cpp b/src/third-party/imgui/imgui.cpp --- a/src/third-party/imgui/imgui.cpp +++ b/src/third-party/imgui/imgui.cpp @@ -5093,6 +5093,9 @@ text_display_end = text_end; ImFont* font = g.Font; + if (!font) { + font = GetDefaultFont(); + }...
 This is what I get after one keystroke with that diff. @db48x IDK if that's tracked in a separate issue or relevant to this particular codepath happening 'pre main...
Interestingly the tiles build actually renders the menu correctly.
Yes, sorry. The messy menu was from imtui (I thought maybe the crash was im_gui_ related). But it happens in both builds. And it only renders okay in imgui. I...
> I wouldn’t make this change here in imgui.cpp. Instead, make sure that `cataimgui::client::load_fonts` is called early enough. So `load_fonts` is called in `catacurses::init_interface();` which happens on line 781 https://github.com/CleverRaven/Cataclysm-DDA/blob/2db2a2ea1991860928044b75c8e1885d9b391ef2/src/main.cpp#L781....
`select_language` doesn't crash if called after `main_menu::opening_screen` so clearly init_interface() isn't initting *enough*.
> this is certainly too much work to skip three checks. You'd be shocked how expensive bounds checks are when you have to do a metaphorical billion of them.
I made a bunch of comments and then realized you were just shuffling code around. So take all my review comments as just 'food for thought'.
That's not the right commit @alef.
/trop run backport