akrieger
akrieger
I'm going to undraft this so I can get ASAN coverage on tests and the other compilers cause I can't easily get mac access to test on.
Only basic build, everything after that gets skipped, including ASAN.
I've updated this PR with an extension on top of the previous code, so if you've seen everything up to "Fix chkjson" / before "Implement json_loader" then you can start...
This is now actually feature complete, but the commits for all the cata_path conversion are not in the best shape and there's more code cleanup to do.
Thanks for finding that, I was having trouble parsing the logs because the expected errors are getting the red text and that one was hidden in all the grey.
Ok, except for that last commit of 'buncha clang tidy fixes' which I'll merge down into the appropriate places, this is ready.
Oh, except Android. Still need to fix Android.
*whew* Android is fixed. UBSan test passed (found one error this morning). clang-tidy is green. I'm going to go ahead and start updating the measurements graphics but I think... it...
``` Error: src/mmap_file.cpp:10:10: fatal error: Windows.h: No such file or directory ``` You have _got_ to be kidding me, cross compiler. [edit: looks like the fix is just rename to...
Something I need to wait for the MXE build to finish to test is whether the path concatenation I'm doing is safe or if I need to add indirection to...