Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Fix software crafting for mods

Open ShnitzelX2 opened this issue 7 months ago • 3 comments

Summary

Bugfixes "fix software crafting for mods"

Purpose of change

  • Fix #79647
  • Fix #80643

In short, the recipe for MatheMAX in "XEDRA: Evolved" specifies putting the newly crafted software into a usb_drive, but instead puts the software in the crafter's hands.

Describe the solution

Adds some checks for e-storage when putting items in containers. This can be safely done because a raw software item should never be obtained and therefore it should never be possible to put it into a container in any case other than item spawning (crafting) or the activity actor that specially handles it.

Describe alternatives you've considered

Testing

Crafted MatheMAX successfully in "XEDRA: Evolved"

Additional context

ShnitzelX2 avatar May 30 '25 15:05 ShnitzelX2

Tests kicked cause I couldn't find the error causing this

+ echo '--mods=dda,xedra_evolved,skyisland,innawood,magiclysm,mindovermatter,DinoMod,defense_mode,bombastic_perkstest exited with code 255'
+ exit_code=1
+ '[' 0 -ne 0 ']'
+ return 1
--mods=dda,xedra_evolved,skyisland,innawood,magiclysm,mindovermatter,DinoMod,defense_mode,bombastic_perkstest exited with code 255

Maleclypse avatar Jun 02 '25 02:06 Maleclypse

OK yep it has failed with the exact same error.

Maleclypse avatar Jun 03 '25 05:06 Maleclypse

Sorry, been busy, I'll test it on my end and draft for now

ShnitzelX2 avatar Jun 08 '25 04:06 ShnitzelX2

(all_mods)=> electrokinetic_see_electric_knack (spell_type) has two definitions from the same source (mindovermatter)!

Looks for me like the actual bug we had a while ago, rebasing should fix it

GuardianDll avatar Jul 09 '25 06:07 GuardianDll

/trop run backport

GuardianDll avatar Jul 13 '25 06:07 GuardianDll

The backport process for this PR has been manually initiated - here we go! :D

migo-chan[bot] avatar Jul 13 '25 06:07 migo-chan[bot]

/trop run backport

akrieger avatar Jul 13 '25 17:07 akrieger

The backport process for this PR has been manually initiated - here we go! :D

migo-chan[bot] avatar Jul 13 '25 17:07 migo-chan[bot]

I have automatically backported this PR to "0.I-branch", please check out #81764

migo-chan[bot] avatar Jul 13 '25 17:07 migo-chan[bot]